Fix concurrent oidc login cookie overwrites#1018
Merged
Conversation
Co-authored-by: contact <contact@ophir.dev>
|
Cursor Agent can help with this pull request. Just |
…kies Co-authored-by: contact <contact@ophir.dev>
… and ensure proper token claims processing
…ration and simplify nonce validation logic
…mprove error handling
Update OIDC redirect URL cookie path to ensure proper handling after authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split OIDC state cookie into two separate cookies to prevent race conditions during concurrent login flows.
Previously, a single
sqlpage_oidc_statecookie was used to store both the nonce and the redirect URL. When multiple OIDC login flows were initiated simultaneously in the same browser, this cookie would be overwritten, leading to authentication failures and loss of the intended redirect target. This change introduces asqlpage_oidc_noncecookie for the nonce and a short-lived, state-specificsqlpage_oidc_state_{csrf_token}cookie for the redirect URL, ensuring each login flow maintains its unique state.